Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Condition the new config doc sections of the extension template #42653

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Condition the new config doc sections of the extension template #42653

merged 1 commit into from
Aug 20, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Aug 20, 2024

When creating projects or extensions, the codestarts from the tooling version are always used even for older versions so we need to be careful about it.

Fixes #42649

@gsmet gsmet requested review from gastaldi and ia3andy August 20, 2024 13:37
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Aug 20, 2024
@gsmet gsmet mentioned this pull request Aug 20, 2024
Closed
ia3andy
ia3andy approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gastaldi
gastaldi approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@gsmet
Condition the new config doc sections of the extension template
d6123f2 
When creating projects or extensions, the codestarts from the tooling
version are always used even for older versions so we need to be
careful about it.

Fixes quarkusio#42649
@gsmet gsmet force-pushed the extension-template-condition branch from fff9f47 to d6123f2 Compare August 20, 2024 15:40
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Aug 20, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit d6123f2.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/micrometer/deployment

✖ io.quarkus.micrometer.deployment.binder.VertxTcpMetricsNoClientMetricsTest.testTcpMetricsWithoutClientMetrics - History

  • event executor terminated - java.util.concurrent.RejectedExecutionException
java.util.concurrent.RejectedExecutionException: event executor terminated
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:931)
	at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:350)
	at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:343)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:833)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:824)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:814)
	at io.vertx.core.impl.EventLoopExecutor.execute(EventLoopExecutor.java:35)

@gsmet gsmet merged commit 361862a into quarkusio:main Aug 20, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Aug 20, 2024
@gsmet gsmet modified the milestones: 3.16 - main, 3.14.0 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform kind/bugfix triage/flaky-test
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.

Extensions created with 999-SNAPSHOT cli depend on non-existing plugin
3 participants
@gsmet @gastaldi @ia3andy